validations: add 'x-kubernetes-validations' validation - #60
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LoginovIlia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XXL
everettraven
left a comment
everettraven
left a comment
There was a problem hiding this comment.
Apologies for the long delay for this review. I've not had much time to dedicate to maintaining this project recently.
Thank you for the contribution and your patience.
db0bde2 to
91427be
Compare
|
@everettraven All fixed |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
91427be to
7ab9194
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LoginovIlia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
removed
the
needs-rebase
7ab9194 to
2d43434
Compare
|
@everettraven Could you please review it again? I've fixed everything we discussed previously. |
3 participants
What this PR does:
I added validation for XValidations based on the issue, because I thought it was important for this repository.
I tried to make the algorithm as simple to read as possible, but it is still not completely clear because I compare structs that do not have a unique field. That is why I build a similar structure in
toValidationRulewith JSON. I need to sort it before comparing, and this also helps me return more readable error messages.Because this is a slice of structs, I added very flexible configuration. I also moved the config checker into the global test package because we can use it in tests for other validators too.
Which issue this PR is related to:
Fixes #50